-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forcats vignette #158
Add forcats vignette #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! My only concern is the number of plots — because the vignette is built and included in the package, this will greatly increase the package size. I know that they're the most effective way of displaying the output but maybe you could use text output in a few more places?
I cut it down to three graphs, showing |
Thanks @robinsones! Can you please check the website in ~10 minutes to make sure it's now also shown there? |
Ooops: https://travis-ci.org/tidyverse/forcats/jobs/481793301#L3141. I forgot about this - you'll need to load dplyr/ggplot2 explicitly and add them to suggests. |
partially solves #149, making another branch with README changes.