Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forcats vignette #158

Merged
merged 5 commits into from
Jan 19, 2019
Merged

Add forcats vignette #158

merged 5 commits into from
Jan 19, 2019

Conversation

robinsones
Copy link
Contributor

@robinsones robinsones commented Jan 19, 2019

partially solves #149, making another branch with README changes.

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! My only concern is the number of plots — because the vignette is built and included in the package, this will greatly increase the package size. I know that they're the most effective way of displaying the output but maybe you could use text output in a few more places?

vignettes/forcats.Rmd Outdated Show resolved Hide resolved
@hadley hadley mentioned this pull request Jan 19, 2019
@hadley hadley changed the title Add forecats vignette Add forcats vignette Jan 19, 2019
@robinsones
Copy link
Contributor Author

I cut it down to three graphs, showing fct_infreq() and fct_reorder(). I also added an example of changing the other_level argument.

@hadley hadley merged commit 937fff7 into tidyverse:master Jan 19, 2019
@hadley
Copy link
Member

hadley commented Jan 19, 2019

Thanks @robinsones! Can you please check the website in ~10 minutes to make sure it's now also shown there?

@robinsones
Copy link
Contributor Author

Unfortunately the website has not updated:

image

@hadley
Copy link
Member

hadley commented Jan 19, 2019

Ooops: https://travis-ci.org/tidyverse/forcats/jobs/481793301#L3141. I forgot about this - you'll need to load dplyr/ggplot2 explicitly and add them to suggests.

@robinsones robinsones mentioned this pull request Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants