Fix all found instances of partial matching #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were found by setting
options(warnPartialMatchAttr = TRUE,
warnPartialMatchDollar = TRUE,
warn = 2)
Using testthat#269 with `options("testthat.suppress" = NULL)` and running
`devtools::test()` and `vtest::vtest()` until there were no more partial
match messages.
There may still be some instances in the code base, but I think this
finds the vast majority.
hadley
added a commit
that referenced
this pull request
Jun 16, 2015
Fix all found instances of partial matching
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found by setting
Using r-lib/testthat#269 with
options("testthat.suppress" = NULL)and runningdevtools::test()andvtest::vtest()until there were no more partialmatch messages.
There may still be some instances in the code base, but I think this
finds the vast majority.