Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all found instances of partial matching #1134

Merged
merged 2 commits into from Jun 16, 2015
Merged

Fix all found instances of partial matching #1134

merged 2 commits into from Jun 16, 2015

Commits on Jun 16, 2015

  1. Fix all found instances of partial matching 

    These were found by setting

options(warnPartialMatchAttr = TRUE,
    warnPartialMatchDollar = TRUE,
    warn = 2)

Using testthat#269 with `options("testthat.suppress" = NULL)` and running
`devtools::test()` and `vtest::vtest()` until there were no more partial
match messages.

There may still be some instances in the code base, but I think this
finds the vast majority.
    @jimhester
    jimhester committed Jun 16, 2015
    Copy the full SHA
    9d2cddc View commit details
    Browse the repository at this point in the history

  2. Add note to NEWS

    @jimhester
    jimhester committed Jun 16, 2015
    Copy the full SHA
    16bd495 View commit details
    Browse the repository at this point in the history