New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement geom_auto #1974

Closed
hadley opened this Issue Dec 30, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@hadley
Member

hadley commented Dec 30, 2016

Should be S3 generic that dispatches on the type of the data argument, which will need to come first.

Helpful for forecast (@robjhyndman) and sf objects.

@hadley

This comment has been minimized.

Member

hadley commented Dec 30, 2016

Possibly should be auto_geom() or auto_layer() since arguments will be rather different to most geoms.

@robjhyndman

This comment has been minimized.

robjhyndman commented Dec 31, 2016

We are using autolayer() in the forecast package (github version). Could change to auto_layer() if you prefer, but we need to decide soon to avoid broken code down the track. I plan to push a new CRAN version of the forecast package in about a month.

@hadley hadley referenced this issue Jan 2, 2017

Closed

Autolayer #1956

@mitchelloharawild

This comment has been minimized.

Contributor

mitchelloharawild commented Jan 4, 2017

Note that I used autolayer() for consistency with autoplot().
Happy for it to be auto_layer(), but if this is used, I'd suggest a similar change for auto_plot().

@hadley

This comment has been minimized.

Member

hadley commented Jan 4, 2017

You're right that it should be autolayer() for consistency. Want to do a PR?

@hadley hadley closed this in #1983 Jan 25, 2017

hadley added a commit that referenced this issue Jan 25, 2017

Added autolayer S3 generic (#1983)
* Added autolayer S3 generic

Closes #1974

* Added news bullet

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.