You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a plot using facet_grid, that I want to set the facet labels with.
The faceting variables are stored as integers, and I am trying to use lookup tables to specify some expressions, and then pass those to label_parsed.
As I read the docs for labeller(), the lookup table should be passed to .default.
.default Default labeller for variables not specified. Also used with lookup tables or non-labeller functions.
However, this doesn't seem to be happening (note labels on rows.)
I'm not sure if this is a documentation problem, me misunderstanding something, or a problem with the labeller.
You're correct. The code doesn't reflect the documentation. If you check out line 440 below, the .default argument is not forwarded to as_labeller(), whereas in line 442 it is. Line 440 is run in your first example, line 442 in your second one.
* Fix labeller to pass .default for lookups (#4031)
Pass .default to as_labeller even when margin_labeller is null, such as
when using named arguements for a lookup table.
* Correct style, and add line to NEWS.md
* Move NEWS bullet into dev version section
Co-authored-by: Kara Woo <woo.kara@gmail.com>
I have a plot using facet_grid, that I want to set the facet labels with.
The faceting variables are stored as integers, and I am trying to use lookup tables to specify some expressions, and then pass those to label_parsed.
As I read the docs for labeller(), the lookup table should be passed to .default.
.default Default labeller for variables not specified. Also used with lookup tables or non-labeller functions.
However, this doesn't seem to be happening (note labels on rows.)
I'm not sure if this is a documentation problem, me misunderstanding something, or a problem with the labeller.
Created on 2020-05-27 by the reprex package (v0.3.0)
If I instead use
.rows
and.cols
to name the arguments to labeller, I get the expected result.(The labels on the rows are now passed to label_parsed)
Created on 2020-05-27 by the reprex package (v0.3.0)
The text was updated successfully, but these errors were encountered: