-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add horizontal linerange geom #1261
Conversation
Maybe @lionel- would you be interested in working on again for the other vertical only geoms? This would also involve deprecating |
it'd also be great to find a solution for dodging. Maybe the Geoms could have a I may work on it again next week but could you be more explicit about what you didn't like in #1128 (besides the repeated code)? |
@lionel- just all the duplicated code. I think with an orient parameter and by using I didn't think about dodging. The easiest approach would probably be an orient param to |
bump. Did this ever happen? I would love to have that functionality ... |
I'm not super excited about this (just because it's something I'm unlikely to use) and since you can now create your own geoms outside of ggplot2, I think a package that provided a whole bunch of horizontal geom variants would be reasonable. |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
I believe this is all done (haven't reoxygenized it). As demonstrated in the example, it's useful when
coord_flip()+ geom_linerange()
is not feasible, e.g. when usingfacet_wrap()
.I'm violating DRY quite a bit here -- it might be better to add an orientation argument to
geom_linerange
? I'm willing to try that if it's thought to be better, but what's here is reasonably useful as is.