Toggle the logic of skipping visual tests #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures are irrelevant to this pull request. #4311 will update the visual cases to fix these. |
clauswilke
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4293
At the time of implementing #4192, I was afraid that visual tests would be silently ignored on the CI (and we would oversight some bugs), so I chose the following logic:
VDIFFR_RUN_TESTSenvvar is explicitly set tofalsebut this ends up failure on CRAN checks. So, this pull request toggle the logic to the following for safety. This should fix the CRAN checks.
VDIFFR_RUN_TESTSenvvar is explicitly set totrue