Fix CI by skipping visual tests when vdiffr is not available #4192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
approved these changes
Sep 6, 2020
thomasp85
pushed a commit
that referenced
this pull request
Dec 14, 2020
* Skip visual tests when vdiffr is not available * Add tweak to skip ggsave tests * Update CMD-ckeck.yml * Add http-user-agent * Fix a comment * Require vdiffr except when it's explicitly disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if systemfonts will be available again on R 3.3 and 3.2 (if we follow the 5 version policy, the support for 3.2 might be dropped), but I think the tests should handle this gracefully anyway, as vdiffr is not actually used for testing on the versions. It seems we also need to skip the ggsave test newly added by #4164 as svglite also depends on systemfonts.
Also, this PR reflects some changes on r-lib/action's check.full.yaml (Use RStudio package manager, and use binary packages on R-devel as well).