WIP: Basic API for tagged missing values #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (TYPEOF(x) != STRSXP) | ||
| Rf_errorcall(R_NilValue, "`x` must be a character vector"); | ||
|
|
||
| int n = Rf_length(x); |
There was a problem hiding this comment.
Do you want to support long vectors here?
And add some more examples
NB: All plumbed up, but doesn't currently do anything
* update readstat api * add tests for reading from stata
And use in the labelled class.
Now preserves all labels in factor levels (labels not in data are added to the end), so is part of #177
|
Your last commit referenced the wrong issue I think. #177 is regarding variable label, did you mean #172? Would you consider moving the sort to the end, so missing labels are sorted in relation to the existing? E.g. changing to something like: # Replace each value with its label
vals <- unique(x)
levs <- replace_with(vals, unname(labels), names(labels))
# Ensure all labels are preserved
levs <- sort(c(setNames(vals, levs), labels))
levs <- unique(names(levs))Would make it so: s1 <- labelled(c(1, 4), c("Agree" = 1, "Neutral" = 2, "Disagree" = 3, "Don't know" = 5))
as_factor(s1)
# Returns:
#> Levels: Agree Neutral Disagree 4 Don't know
# Instead of:
#> Levels: Agree 4 Neutral Disagree Don't know |
|
Closing because it's now so massive that it's impossible to review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
To do:
as_factor()can re-label tagged missingsas_factor())