Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve NA when converting to strings #51

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Preserve NA when converting to strings #51

merged 1 commit into from
Jan 23, 2018

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Nov 20, 2017

I may be overlooking something, but why are NAs not preserved?

@krlmlr
Copy link
Member

krlmlr commented Nov 21, 2017

Good point. We need an NA string for format(), but maybe this still works with your patch? Existing tests seem to pass, would you like to add an explicit test for as.character() and maybe format()?

@jimhester
Copy link
Contributor

FWIW the current behavior was the ultimate cause of a reported readr bug tidyverse/readr#715, which should be fixed once this is merged.

@krlmlr
Copy link
Member

krlmlr commented Jan 23, 2018

Thanks!

krlmlr added a commit that referenced this pull request Jan 24, 2018
- Preserve `NA` when converting to `character` (#51, @jeroen).
- Adapted tests to pillar 1.1.0.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants