Implemented accumulate for recursive folding #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' | ||
| #' rerun(5, rnorm(100)) %>% setNames(paste0("sim", 1:5)) %>% | ||
| #' map(~ accumulate(., function(.x, .y) .05 + .x + .y)) %>% | ||
| #' map(~ data.frame(value = .x, step = 1:100)) %>% |
There was a problem hiding this comment.
This could now be map_df(~ data_frame(value = .x, step = 1:100), .id = "simulation")
|
Looks good - thanks! Can you please respond to my super nitpicky comments and add a bullet to NEWS? |
…the new functions.
|
Super nitpicky is super helpful! I didn't notice the addition of I also did a little additional formatting to the examples. Hopefully they'll be a little easier to read. In retrospect, one of my examples didn't illustrate what I expected (the flooring and capping). It's dropped. I also went ahead and added |
…ight(), accumulate() and accumulate_right()
…ight(), accumulate() and accumulate_right()
hadley
added a commit
that referenced
this pull request
Dec 7, 2015
Implemented accumulate for recursive folding
|
Looks great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #46 and #11, I implemented a version of
accumulate, which adds recursive folding to the package.The differences between
accumulateandreduceare minor. I simply added another argument (accumulate = TRUE) to the call ofReduce. Nonetheless, this change provides a lot of utility.I have two examples in the documentation. The first shows flooring and capping a dataset, which is an extension of an example in Haskell's scanl documentation. The second example shows a simple simulation of a random walk with drift.