Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepend() with empty list #654

Closed
wants to merge 2 commits into from
Closed

Fix prepend() with empty list #654

wants to merge 2 commits into from

Conversation

czeildi
Copy link
Contributor

@czeildi czeildi commented Mar 3, 2019

  • changes default value for before argument from 1 to NULL
  • behaviour is identical for non-empty list
  • by default now appends at the beginning for empty list instead throwing an error
  • if before is not NULL, still throws error for empty list
  • error message now includes NULL check for all cases

Fixes #637

@czeildi
Copy link
Contributor Author

czeildi commented Jul 7, 2019

I redid this PR #687 to follow best practices described in https://happygitwithr.com/fork-and-clone.html, now PR from a non-master branch

@czeildi czeildi closed this Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepend: fails for empty list
1 participant
@czeildi