Make modify_depth() and map_depth() consistent with modify_tree() #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Sep 26, 2022
| @@ -8,7 +8,8 @@ | |||
| #' @param leaf A function applied to each leaf. | |||
| #' @param is_leaf A predicate function that determines whether an element is | |||
| #' a leaf (by returning `FALSE`) or a node (by returning `FALSE`). The | |||
| #' default value, `NULL`, treats lists as nodes and everything else as leaves. | |||
| #' default value, `NULL`, treats bare lists as nodes and everything else | |||
There was a problem hiding this comment.
I'm going to leave this as is since once I switch to is_node instead of is_leaf the default will become vec_is_list() and then it's obvious.
|
|
||
| x <- list(data.frame(x = 1), data.frame(y = 1)) | ||
| expect_equal( | ||
| map_depth(x, 2, class, .is_leaf = Negate(is.list)), |
There was a problem hiding this comment.
The use of Negate makes me wonder if it wouldn't be better to take is_node instead of is_leaf?
There was a problem hiding this comment.
Yeah, I wondered about this too. I might do it in a separate PR.
Co-authored-by: Lionel Henry <lionel.hry@gmail.com>
Create new vctrs compatibility helper, and use it in a few places. "Weird" vectors like pairlists, expressions, and calls have been deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958