read_excel now accepts a vector of NA types #136
Conversation
pass number 2 pass number 3 pass number 4 pass number 5 pass number 6 pass number 7 pass number 8 pass number 9 pass number 10 Finished source edit, appears to work; updated man page for read_excel
|
Not sure why Travis / |
| @@ -48,13 +48,13 @@ inline std::string cellTypeDesc(CellType type) { | |||
|
|
|||
| inline CellType cellType(xls::st_cell::st_cell_data cell, xls::st_xf* styles, | |||
| const std::set<int>& customDateFormats, | |||
| std::string na = "") { | |||
| std::vector<std::string> na = {""}) { | |||
There was a problem hiding this comment.
That needs to be a const std::vector<std::string>& otherwise the complete vector gets copied each time
There was a problem hiding this comment.
Is that default value a C++11 extension?
There was a problem hiding this comment.
@hadley Thanks for the tip! This is honestly my first piece of C++ code so I can't say I have the slightest idea which bits are 11-specific or not.
Before repairing this pull, I noticed after submitting this request that there's an outstanding pull request that seems to accomplish the same thing and from what I see was just about ready to be merged, was there something wrong with that code that I missed?
Don't want to duplicate efforts here.
|
Closed as duplicate of #56 |
Can be tested on this test Excel file:
https://drive.google.com/file/d/0B1i6iIc4UbO1VUV6TWQ0RjlFT1U/view?usp=sharing
Using this code:
I get this output, as expected: