Support multiple na values #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ parse_ref <- function(ref) { | |||
| .Call('readxl_parse_ref', PACKAGE = 'readxl', ref) | |||
| } | |||
|
|
|||
| xlsx_col_types <- function(path, sheet = 0L, na = "", nskip = 0L, n = 100L) { | |||
| xlsx_col_types <- function(path, sheet = 0L, na = as.character( c()), nskip = 0L, n = 100L) { | |||
There was a problem hiding this comment.
A more compact form is character()
There was a problem hiding this comment.
Ah - by the looks the Rcpp attributes compilation changed in 0.11.1. Instead of CharacterVector::create() to create a default, you should now use CharacterVector().
Fixed.
|
Looks great apart from that one tiny problem |
|
Rebased + updated. |
|
@jmarshallnz @hadley any activity here? Wondering whether to patch up #136 or not. |
|
Looks good - just needs a bullet point in NEWS. @jennybc can you please merge when ready? (or add the bullet point if @jmarshallnz has moved on to other things) |
|
I can do it on the 24th. On holiday ATM
…On Thu, 19 Jan 2017 at 6:06 AM, Hadley Wickham ***@***.***> wrote:
Looks good - just needs a bullet point in NEWS.
@jennybc <https://github.com/jennybc> can you please merge when ready?
(or add the bullet point if @jmarshallnz <https://github.com/jmarshallnz>
has moved on to other things)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAY0KzeDLPeuQUSOF9wuHYJnxuYs3OsIks5rTkaFgaJpZM4D90xi>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of #13, and fixes a bug where NA = "1" didn't work for .xls sheets.