Switch to tibble::set_tidy_names() from tibble::repair_names() #453
Conversation
NEWS.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # readxl 1.0.0.9000 | |||
|
|
|||
| * Missing or duplicated column names are now repaired with `tibble::set_tidy_names()` in `read_excel()` and friends. `set_tidy_names()` is intended to implement a standard across the tidyverse packages for repairing missing and duplicated names. Its design is discussed in [tidyverse/tibble#217](https://github.com/tidyverse/tibble/issues/217). (PR here, #357) | |||
There was a problem hiding this comment.
You might also want to include as a heading under a "Breaking changes" section where you describe the issue from the symptoms (i.e. how have names changed), and offer a work around in code.
There was a problem hiding this comment.
Roger re: "Breaking changes"
offer a work around in code
Well that's the problem. I don't really offer one right now. To offer a nice one ... I think I'd need to add an argument that affects name repair. Is it worth it?
The only workaround possible with the current strategy would be a post hoc regex-based renaming strategy, given what I know about the old and new repaired names.
There was a problem hiding this comment.
I don't you need to have the workaround in the package functions, instead you can provide code for one in the NEWS.md + release blog post.
|
I'm going to hold off on merging this, but will foreshadow in NEWS/blog post. Will do shortly after release, so people have time to adjust. Would be obvious to combine in a CRAN release with col spec improvements. |
|
pkgconfig works for me in these situations: We could start with opt-in even before CRAN release, and just switch the default after CRAN release. CC @gaborcsardi. |
Resolves #357 Our discussion about name repair is here: tidyverse/tibble#217
Resolves #357
Recall previous discussion about name repair, that lead to
tibble::set_tidy_names(): tidyverse/tibble#217I would really like to make this change. And I predict that revdep checks will reveal few/no problems with this move in packages.
But I also know from the previous release that any change here generates a lot of upset and issues, as people have scripts that are hardwired to whatever the previous name repair strategy was. It also always brings up the usual suggestions to clean up nonsyntactic names. Quoting @hadley from thread linked above:
Thoughts on whether and how to proceed?