Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print something for str_view(character()) #497

Closed
hadley opened this issue Jan 26, 2023 · 0 comments · Fixed by #568
Closed

Print something for str_view(character()) #497

hadley opened this issue Jan 26, 2023 · 0 comments · Fixed by #568
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@hadley
Copy link
Member

hadley commented Jan 26, 2023 •
edited
Loading

Should be adequate to fix just print.stringr_view() by adding a special case for n = 0. I'm not sure what it should print though! Probably just something that it says "no strings", but more nicely 😄

Will need a snapshot test.
@hadley hadley added the feature a feature request or enhancement label Aug 4, 2023
@hadley hadley added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jul 15, 2024
LouisMPenrod added a commit to LouisMPenrod/stringr that referenced this issue Aug 15, 2024
@LouisMPenrod
Adds a message when an empty string is provided instead of returning …
04c46d5 
…nothing. Existing snapshot updated.

Fixes tidyverse#497
@LouisMPenrod LouisMPenrod mentioned this issue Aug 15, 2024
Merged
@hadley hadley closed this as completed in 1562054 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a message when an empty string is provided LouisMPenrod/stringr
1 participant
@hadley