Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for row names #114

Closed
krlmlr opened this issue Jul 3, 2016 · 23 comments
Closed

Remove support for row names #114

krlmlr opened this issue Jul 3, 2016 · 23 comments

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 3, 2016

Complicates the code. Should first warn when accessing (r/w) row names of a data frame, and then (in a following version) discard them when coercing.

@zeehio

This comment was marked as off-topic.

@krlmlr

This comment has been hidden.

@zeehio

This comment has been hidden.

@flying-sheep

This comment has been hidden.

@krlmlr

This comment was marked as off-topic.

@flying-sheep

This comment has been hidden.

@michaellevy

This comment has been hidden.

@krlmlr

This comment has been hidden.

@michaellevy

This comment has been hidden.

@krlmlr

This comment has been hidden.

@michaellevy

This comment has been hidden.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 19, 2018

Thanks. An argument to as_tibble() (and to as.data.frame.tibble()) seems like a simple solution.

@hadley

This comment has been hidden.

@krlmlr

This comment has been hidden.

@hadley

This comment has been hidden.

@krlmlr

This comment has been hidden.

@krlmlr krlmlr added this to the 1.5.0 milestone Aug 20, 2018
@hadley

This comment has been hidden.

@krlmlr

This comment has been hidden.

@krlmlr

This comment has been hidden.

@hadley

This comment has been hidden.

@krlmlr

This comment has been hidden.

@hadley
Copy link
Member

@hadley hadley commented Oct 22, 2018

The only new behaviour in this version is that as_tibble() now strips rownames (as it probably always should have). You can get the previous behaviour by setting rownames = NA (or pkgconfig::set_config("tibble::rownames", NA) to affect all code in a package), and there's a convenient way to turn rownames into a variable: rownames = "new_variable_name". This seems like a small change and unlikely to cause problems.

@github-actions
Copy link

@github-actions github-actions bot commented Dec 9, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants