Coerce to data frame in column_to_rownames()#517
Merged
krlmlr merged 2 commits intotidyverse:masterfrom Oct 24, 2018
Merged
Conversation
Member
Author
|
Not sure we should touch |
hadley
approved these changes
Oct 22, 2018
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Also needs a update to the docs; I'd suggest using @return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114 -- the last bits of that issue, stripping row names in
as_tibble()is already implemented.