New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object summary vignette #151

Merged
merged 3 commits into from Aug 18, 2016

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented Aug 16, 2016

Currently a first draft, @hadley: please review. I'm attaching a rendered version in the next comment.

Fixes #96.

@krlmlr krlmlr added the in progress label Aug 16, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Aug 16, 2016

@hadley

This comment has been minimized.

Member

hadley commented Aug 16, 2016

What's the easiest way for me to just edit the rmd directly? Maybe you should just merge this, and then I'll take a whack at it?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Aug 16, 2016

Local checkout:

git fetch --all
git checkout "f-#96-obj-sum"

Please push to this branch at your convenience.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Aug 16, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Aug 16, 2016

Current coverage is 99.61% (diff: 100%)

Merging #151 into master will increase coverage by 0.03%

@@             master       #151   diff @@
==========================================
  Files            16         16          
  Lines           704        776    +72   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            701        773    +72   
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update 927ae40...64ba992

@krlmlr

This comment has been minimized.

Member

krlmlr commented Aug 16, 2016

Thanks, it's a lot clearer now. Mind if I add you as author?

@hadley

This comment has been minimized.

Member

hadley commented Aug 17, 2016

Go for it

@krlmlr krlmlr merged commit c47b30b into master Aug 18, 2016

0 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@krlmlr krlmlr deleted the f-#96-obj-sum branch Aug 18, 2016

@krlmlr krlmlr removed the in progress label Aug 18, 2016

krlmlr added a commit that referenced this pull request Aug 18, 2016

Merge tag 'v1.1-8'
- The `tibble.width` option is used for `glimpse()` only if it is finite (#153).
- Add guidance to install `nycflights13` package to examples (#152).
- New object summary vignette that shows which methods to define for custom vector classes to be used as tibble columns (#151).
- `as_tibble.matrix()` doesn't remove the `"class"` attribute anymore, to support (again) conversion of `factor` and `Date` matrices (#110, #154).
- New `as_tibble.poly()` to support conversion of a `poly` object to a tibble.

krlmlr added a commit that referenced this pull request Aug 26, 2016

Merge tag 'v1.2'
- The `tibble.width` option is used for `glimpse()` only if it is finite (#153, @kwstat).
- New `as_tibble.poly()` to support conversion of a `poly` object to a tibble (#110).
- `add_row()` now correctly handles existing columns of type `list` that are not updated (#148).
- `all.equal()` doesn't throw an error anymore if one of the columns is named `na.last`, `decreasing` or `method` (#107, @BillDunlap).

- New `add_column()`, analogously to `add_row()` (#99).
- `print.tbl_df()` gains `n_extra` method and will have the same interface as `trunc_mat()` from now on.
- `add_row()` and `add_column()` gain `.before` and `.after` arguments which indicate the row (by number) or column (by number or name) before or after which the new data are inserted. Updated or added columns cannot be named `.before` or `.after` (#99).
- Rename `frame_data()` to `tribble()`, stands for "transposed tibble". The former is still available as alias (#132, #143).

- `add_row()` now can add multiple rows, with recycling (#142, @jennybc).
- Use multiply character `×` instead of `x` when printing dimensions (#126). Output tests had to be disabled for this on Windows.
- Back-tick non-semantic column names on output (#131).
- Use `dttm` instead of `time` for `POSIXt` values (#133), which is now used for columns of the `difftime` class.
- Better output for 0-row results when total number of rows is unknown (e.g., for SQL data sources).

- New object summary vignette that shows which methods to define for custom vector classes to be used as tibble columns (#151).
- Added more examples for `print.tbl_df()`, now using data from `nycflights13` instead of `Lahman` (#121), with guidance to install `nycflights13` package if necessary (#152).
- Minor changes in vignette (#115, @helix123).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment