Respect grouping in fill(). Fixes #129

tidyverse · Dec 30, 2015 · 849aab5 · 849aab5
1 parent cdc0baf
commit 849aab5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # tidyr 0.3.1.9000
 
+* `fill()` respects grouping from `group_by()` (#129).
+
 * `fill()` fills in `NULL`s in list-columns.
 
 * `fill()` gains a direction argument so that it can fill either upwards or 

diff --git a/R/fill.R b/R/fill.R
@@ -51,3 +51,8 @@ fill_.data.frame <- function(data, fill_cols, .direction = c("down", "up")) {
 
   data
 }
+
+#' @export
+fill_.grouped_df <- function(data, fill_cols, .direction = c("down", "up")) {
+  do(data, fill_(., fill_cols = fill_cols, .direction = .direction))
+}
diff --git a/tests/testthat/test-fill.R b/tests/testthat/test-fill.R
@@ -73,3 +73,9 @@ test_that("fill preserves attributes", {
   expect_equal(attributes(out_d$x), attributes(df$x))
   expect_equal(attributes(out_u$x), attributes(df$x))
 })
+
+test_that("fill respects grouping", {
+  df <- dplyr::data_frame(x = c(1, 1, 2), y = c(1, NA, NA))
+  out <- df %>% dplyr::group_by(x) %>% fill(y)
+  expect_equal(out$y, c(1, 1, NA))
+})