Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_autoware_utils): fix build error #296

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Mar 1, 2023

Description

#282 でビルドエラーが発生するようになってしまっているため修正
また、テストでエラーが起きる。これはテスト部分のコードが移植できていないため
autowarefoundation#1268 より移植する

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta changed the title fix(tier4_autoware_utils): build_error fix(tier4_autoware_utils): fix build error Mar 1, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.14@e9ebd09). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@               Coverage Diff               @@
##             beta/v0.3.14     #296   +/-   ##
===============================================
  Coverage                ?   10.05%           
===============================================
  Files                   ?      499           
  Lines                   ?    40239           
  Branches                ?     8293           
===============================================
  Hits                    ?     4047           
  Misses                  ?    32677           
  Partials                ?     3515           
Flag Coverage Δ
differential 10.05% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta h-ohta requested review from sfukuta and yn-mrse March 1, 2023 10:01
@yn-mrse
Copy link

yn-mrse commented Mar 1, 2023

local環境でのbuild確認パス済みです。
問題ないと思います!

@yn-mrse yn-mrse merged commit 8d49017 into beta/v0.3.14 Mar 1, 2023
@yn-mrse yn-mrse deleted the fix/build_error branch March 1, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants