Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): pull_over far goal bug (#1571) #93

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Aug 13, 2022

Description

cherry-pick
autowarefoundation#1571
for v0.5.0

Solved a problem where setting a goal after a loop pull_over did not work well. Because current_lanes does not contain goal, goal_arc_length cannot be calculated correctly (it becomes 0) and pull_oevr module is invoked. In addition, arc_length could not be calculated properly in the module processing, this caused bug.
In this PR, when a goal is far away and current_lanes does not contain the goal, the module will not be launched.

Related links

autowarefoundation#1571

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…n#1571)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@tkimura4 tkimura4 merged commit fd7654b into beta/v0.5.0 Aug 16, 2022
@tkimura4 tkimura4 deleted the fix/pull_over_far_goal_v0.5.0 branch August 16, 2022 05:48
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants