Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable to build with both ros1 and ros2 #16

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Oct 20, 2022

Closes #14 #15

@wep21 wep21 requested a review from esteve October 20, 2022 14:31
@wep21
Copy link
Contributor Author

wep21 commented Oct 20, 2022

@ipa-danb @Levi-Armstrong @esteve
Could you review this PR? This PR enables to build the package with both ros1 and ros2 and modify noetic build. I will create a release for noetic after this PR is merged.

Daisuke Nishimatsu added 2 commits October 20, 2022 23:59
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Copy link

@Levi-Armstrong Levi-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ipa-danb
Copy link

LGTM, too

@Levi-Armstrong
Copy link

@wep21 Thanks for making the fix!

Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit a05a1b3 into main Oct 23, 2022
@wep21 wep21 deleted the feature/hybrid-package branch October 23, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noetic Release is failing
4 participants