Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider committing Cargo.lock #35

Closed
polyzen opened this issue Nov 5, 2018 · 5 comments
Closed

Please consider committing Cargo.lock #35

polyzen opened this issue Nov 5, 2018 · 5 comments

Comments

@polyzen
Copy link

polyzen commented Nov 5, 2018

error: the lock file needs to be updated but --locked was passed to prevent this

@polyzen polyzen changed the title Please update the lock file Please consider using Cargo.lock Nov 5, 2018
@polyzen polyzen changed the title Please consider using Cargo.lock Please consider committing Cargo.lock Nov 5, 2018
@polyzen
Copy link
Author

polyzen commented Nov 6, 2018

Looks like this would also be needed:
rust-lang/cargo#5654

@tiffany352
Copy link
Owner

This will make it so that the CLI you install from crates.io won't fail to build when a dependency updates? I haven't been keeping up with this, I'm not quite sure why this requires a special cargo feature flag to be enabled.

@polyzen
Copy link
Author

polyzen commented Nov 6, 2018

Exactly, for reproducible builds.

This gives people the ability to commit their lock files and ship them with binary crates, avoiding:
https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

@polyzen
Copy link
Author

polyzen commented Nov 8, 2018

I've learned unstable Cargo features require Cargo nightly. Will bump this once it's stabilized.

@polyzen polyzen closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants