Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packetsReceived not reset every minute #148

Open
wangxjfrombj opened this issue May 1, 2022 · 3 comments
Open

packetsReceived not reset every minute #148

wangxjfrombj opened this issue May 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@wangxjfrombj
Copy link

wangxjfrombj commented May 1, 2022

Describe the bug
if something wrong when run everyMinute() in class ConnectionManager, Timer stop run continue

To Reproduce
Steps to reproduce the behavior:

  1. Go to ConnectionManager
  2. receiverTasks.scheduleAtFixedRate
  3. everyMinute()
  4. doForAllServices(ServiceChecker checker)
  5. service is null

Impact
packetsReceived not reset every minute, XMPP Limits exceeded on connection

@wangxjfrombj wangxjfrombj added the bug Something isn't working label May 1, 2022
@woj-tek
Copy link
Contributor

woj-tek commented May 2, 2022

Could you explain in more details "something wrong when run everyMinute()"? Do you mean some exception is thrown? Do you have any custom code?

Indeed if the statistics are not collected/cleared periodically it could lead to the impression that the metrics are growing and there is something wrong with the installation, but to investigate it properly we need more details.

@wangxjfrombj
Copy link
Author

I add some code like below, so far, "XMPP Limits exceeded on connection" not appear in the log again.
(1) AbstractMessageReceiver.java , receiverTasks.scheduleAtFixedRate(...), everyMinute() surround with try catch
(2) ConnectionManager.java ,doForAllServices(...), if (service != null) { checker.check(service); }
The problem rarely occurs,I am not sure the fix is valid.

@woj-tek
Copy link
Contributor

woj-tek commented May 20, 2022

I wasn't asking about your attempt at the fix of the problem but if you had any custom code in Tigase at all.

Could you share complete exception Stacktrace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants