Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable metrics #573

Merged
merged 1 commit into from
Oct 3, 2022
Merged

feat: configurable metrics #573

merged 1 commit into from
Oct 3, 2022

Conversation

pboros
Copy link
Contributor

@pboros pboros commented Oct 3, 2022

  • Quantiles reported are configurable, example:
metrics:
  quantiles:
    - 0.5
    - 0.95
    - 0.99

The default is 0.5 and 0.95.

  • Individual metrics groups are configurable, example:
metrics:
  fdb:
    enabled: false
  • The configuration options provided are granular enough to account for all the use cases. For example, for size metrics, the collections of namespace, db and collection sizes are configurable separately.

  • Histograms can be enabled for metric groups (disabled by default)

  • Tags for metric groups can be filtered.
    Example:

metrics:
  requests:
    filtered_tags:
      - grpc_service

A filtered tag is not included in the metrics provided.

  • The grpc_service and the grpc_service_type tags are removed, they were redundant with grpc_method.

@pboros pboros force-pushed the pboros/configurable-metrics branch 2 times, most recently from 14d71ef to 106fcce Compare October 3, 2022 13:55
@codecov-commenter
Copy link

Codecov Report

Base: 30.07% // Head: 30.01% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (106fcce) compared to base (1d24c42).
Patch coverage: 33.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   30.07%   30.01%   -0.06%     
==========================================
  Files          89       89              
  Lines       10552    10659     +107     
==========================================
+ Hits         3173     3199      +26     
- Misses       7078     7157      +79     
- Partials      301      303       +2     
Impacted Files Coverage Δ
server/metrics/fdb.go 94.59% <ø> (-0.53%) ⬇️
server/metrics/query.go 66.66% <0.00%> (ø)
server/metrics/requests.go 100.00% <ø> (ø)
server/metrics/search.go 100.00% <ø> (ø)
server/metrics/session.go 100.00% <ø> (ø)
server/middleware/auth.go 30.43% <0.00%> (ø)
server/middleware/measure.go 0.00% <0.00%> (ø)
server/middleware/middleware.go 0.00% <0.00%> (ø)
server/request/request.go 16.78% <0.00%> (+0.24%) ⬆️
server/services/v1/sessions.go 5.64% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pboros pboros force-pushed the pboros/configurable-metrics branch from 106fcce to 957c151 Compare October 3, 2022 14:25
@pboros pboros force-pushed the pboros/configurable-metrics branch from 957c151 to 505889b Compare October 3, 2022 14:29
@pboros pboros merged commit 765d8d8 into main Oct 3, 2022
@pboros pboros deleted the pboros/configurable-metrics branch October 3, 2022 16:51
pboros added a commit that referenced this pull request Oct 4, 2022
@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants