Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserResponseParser.GetUsers() throws an exception when no users have been defined on the server #34

Closed
meverett opened this issue Dec 12, 2016 · 3 comments
Closed

UserResponseParser.GetUsers() throws an exception when no users have been defined on the server #34

meverett opened this issue Dec 12, 2016 · 3 comments

Comments

@meverett
Copy link
Contributor

If you call GetUsersAsync() on the UserClientModule when no users have been defined on the InfluxDB server the UserResponseParser.GetUsers() method will throw an unhandled exception.

The code tries to send back an empty list when there are no results by copying the same technique from other response parsers but in this case the InfluxDB server returns a series with no values which doesn't get caught by the current conditional logic.

The fix is pretty simple and I've submitted pull request #33 to address it.
@meverett meverett mentioned this issue Dec 12, 2016
Merged
@tihomir-kit
Copy link
Owner

Hey man, thanks for this. I'll merge it in and deploy this weekend.

@tihomir-kit
Copy link
Owner

Will deploy this in a new nuget version tomorrow (today :D). Cheers!

@tihomir-kit
Copy link
Owner

Deployed with v6,0,1. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meverett @tihomir-kit