Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eye of adjacency matrix is added twice #23

Closed
zfnWong opened this issue Oct 5, 2020 · 3 comments
Closed

eye of adjacency matrix is added twice #23

zfnWong opened this issue Oct 5, 2020 · 3 comments

Comments

@zfnWong
Copy link

zfnWong commented Oct 5, 2020

  1. load_reddit_data() in utils.py - adj = adj + adj.T + sp.eye(adj.shape[0])
  2. aug_normalized_adjacency(adj) in normalization.py - adj = adj + sp.eye(adj.shape[0])
    In load_reddit_data() from utils.py, after calling adj_normalizer(), eye of adj is added to adj twice.
@zfnWong zfnWong closed this as completed Oct 5, 2020
@zfnWong zfnWong reopened this Oct 5, 2020
@Tiiiger
Copy link
Owner

Tiiiger commented Oct 6, 2020

@wangzefan666 hi Thank you for pointing this out.

Looks like this is a bug. I will look into how it affects the accuracy of SGC today.

@Tiiiger
Copy link
Owner

Tiiiger commented Oct 13, 2020

hi @wangzefan666

sorry for a late reply, finally got a chance to look at this.

Yeah, I think you are right. After I fix this bug, SGC performance goes from 94.9 to 95.0. So I guess it's all good. I am pushing the fix commit now.

@Tiiiger Tiiiger closed this as completed Oct 13, 2020
@zfnWong
Copy link
Author

zfnWong commented Oct 13, 2020

It is my pleasure to receive response from you.
I'm so glad that my advice is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tiiiger @zfnWong