Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full migration to labwc #582

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Full migration to labwc #582

merged 2 commits into from
Jun 5, 2024

Conversation

humaidtii
Copy link
Member

@humaidtii humaidtii commented Apr 29, 2024

Full migration to labwc, removing Weston compositor support and adding hi-res icons for apps.

This also fixes labwc performance issues and other bugs in Jetson Orin.

Depends on: #539

Description of changes

Weston was deprecated in Ghaf 24.03, now removal for Ghaf 24.06. With Weston removed, we do not need to provide backwards compatibility.

  • Completely remove weston implementation & configuration.
  • Use Papirus icon theme for all launcher entries.
    • Remove icon assets as they are replaced by the theme.
    • Created subset of Papirus icon theme package to only include icons we use.
    • Remove power icons custom package.
  • Fix letter casing for launcher entries.
  • Fix labwc performance issues on Jetson Orin by using gles2.
    • Renderer can be defined as an option.
  • Fix duplicate icons in drawer.
  • Replace i3lock with gtklock, make it match system theme.
  • Added window icons from Figma.
    • Had to create custom package ghaf-openbox-theme.
  • Include default fonts in the system.

Known issues

  • Cannot interact with gtklock using mouse, only keyboard.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

  • labwc available on all platforms, no major performance issues.
  • New icon theme available for all launcher icons.
  • No more duplicate icons in the drawer on Orin.
  • Lock screen should work as expected. When autolock is enabled, there is dimming before locking.
  • Enrol with fingerprint, test fingerprint login with gtklock (there are pre-existing quirks with this feature).

@humaidtii humaidtii temporarily deployed to internal-build-workflow April 29, 2024 17:01 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 29, 2024 17:14 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 29, 2024 17:26 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 29, 2024 17:49 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 30, 2024 09:46 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 30, 2024 11:33 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 30, 2024 11:34 — with GitHub Actions Inactive
@humaidtii humaidtii changed the title Weston removal and add icon pack Full migration to labwc Apr 30, 2024
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 30, 2024 12:26 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow April 30, 2024 12:47 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow May 1, 2024 09:26 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow May 1, 2024 09:43 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow May 1, 2024 09:46 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow May 7, 2024 06:32 — with GitHub Actions Inactive
@humaidtii humaidtii changed the base branch from main to ghaf-unstable May 7, 2024 06:32
@humaidtii humaidtii force-pushed the weston-rm branch 3 times, most recently from 410ea7d to 402eda1 Compare May 7, 2024 08:15
@milva-unikie
Copy link

Tested on Lenovo-X1 (used commit 1b4c539)

  • Test-automation passes (except app tests that need to be updated. I created a PR for that so the change is ready to go into test-automation when this PR is merged).
  • Performance ok.
  • All apps launch.

These old notes are still valid:

  • On the lock screen, the Unlock-button does not work. Also, the password cannot be seen with the button to the right of the password field. Pressing enter works to confirm the password.
  • If you have registered a fingerprint but are using a password to log in, it will take about 30 seconds for the laptop to open.
  • When entering the fingerprint on lock screen, the screen sometimes goes black (mouse can be seen). This doesn't happen every time, but it is happening regularly. The only way to recover I found is to reboot the laptop.

brianmcgillion and others added 2 commits June 5, 2024 05:20
Use the latest patches from tiiuae/nixpkgs so that the labwc builds and
also that the pipewire drops the qt dependency

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
This patch fully migrates Ghaf to labwc, removing Weston compositor
support, improves usability and performance of the labwc environment.

Signed-off-by: Humaid Alqasimi <humaid.alqassimi@tii.ae>
@humaidtii humaidtii temporarily deployed to internal-build-workflow June 5, 2024 05:10 — with GitHub Actions Inactive
@humaidtii humaidtii temporarily deployed to internal-build-workflow June 5, 2024 05:13 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit 2f82457 into tiiuae:main Jun 5, 2024
25 checks passed
@humaidtii humaidtii deleted the weston-rm branch June 7, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants