-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
labwc redesign, Gnome removal #539
Conversation
fc41771
to
b66f7fc
Compare
b66f7fc
to
37f1fd3
Compare
37f1fd3
to
5a78a71
Compare
5a78a71
to
b729f8b
Compare
b729f8b
to
4a5c7cb
Compare
4a5c7cb
to
7ec6092
Compare
7ec6092
to
b6669aa
Compare
a12b4cc
to
dfc9dd8
Compare
dfc9dd8
to
c8230a2
Compare
Tested on X1
Overall I think this looks amazing and is working really well. However, a few notes about the GUI and usability.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test results for native Orin AGX build
nix build github:humaidtii/ghaf/labwc-redesign#nvidia-jetson-orin-agx-debug-flash-script
- App menu has duplicate icons for Element, Firefox and Zathura (only one icon works though)
- Element didn't launch by clicking its icon(s)
- There is some lag or quite long response time in moving the mouse
- ci-test-automation tests ok
Same also with Orin NX. There are duplicate icons in drawer and the user interface is quite laggy. |
c8230a2
to
1eae3af
Compare
This aligns the system design closer to the prototypes in Figma. Signed-off-by: Humaid Alqasimi <humaid.alqassimi@tii.ae>
Can be added later when proper support is implemented. Signed-off-by: Humaid Alqasimi <humaid.alqassimi@tii.ae>
1eae3af
to
2103c13
Compare
This is due to how the window border is drawn, this is an issue before but now it is probably more obvious. This needs a proper overhaul to make it secure.
Seems to be same behaviour as before. Waybar with
This used to exist before, but more obvious now. This needs a proper fix as VMs should not be able to draw shadows on the gui-vm. This would be fixed along with the first issue.
Interesting observation, this is probably an app-dependant behaviour that is out of our control. Orin should now be using Weston again. Another PR is created for full labwc migration. |
Tested on X1
Tested on Orin-NX
|
This aligns the system design closer to the prototypes in Figma, improving UI/UX state of Ghaf. Also as Gnome is not functional, it is removed.
Description of changes
labwc redesign
~
).Gnome removal
Removed as Gnome is not officially supported or working. If it is later decided Gnome should be supported, it should be brought back as a separate PR with proper support.
Checklist for things done
x86_64
aarch64
riscv64
nix flake check --accept-flake-config
and it passesTesting