Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump: Use the nixpkgs/nixos-unstable again #628

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Bump: Use the nixpkgs/nixos-unstable again #628

merged 8 commits into from
Jun 3, 2024

Conversation

brianmcgillion
Copy link
Collaborator

Carried patches are now merged to unstable so bumping to include latest fixes in unstable.

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 23, 2024 03:16 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion marked this pull request as draft May 23, 2024 03:16
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 23, 2024 11:20 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 24, 2024 09:58 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 24, 2024 13:34 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 24, 2024 15:27 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion marked this pull request as ready for review May 24, 2024 16:16
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label May 24, 2024
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 24, 2024 17:03 — with GitHub Actions Inactive
@milva-unikie
Copy link

Lenovo-X1 does not boot. In bootloader the only option is to Reboot Into Firmware Interface.

@johannarautanen
Copy link

Test results on Orin-AGX:

  • Automated bat-tests OK
  • All Apps working

No new findings.

@brianmcgillion
Copy link
Collaborator Author

Lenovo-X1 does not boot.

Can you explain how you are testing? Installed image, from ssd, or with rebuild?

@milva-unikie
Copy link

Can you explain how you are testing? Installed image, from ssd, or with rebuild?

Built the image with nix build github:brianmcgillion/ghaf/flake-bump-unstable#lenovo-x1-carbon-gen11-debug and flashed on ssd. I tried two different ssds, same result with both.

@leivos-unikie
Copy link
Contributor

Tested on icicle-kit, nuc and vm-debug. No issues found on those targets.

@leivos-unikie leivos-unikie added Tested on NUC This PR has been tested on Intel NUC Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board labels May 27, 2024
@johannarautanen
Copy link

Test results on Orin-NX:

Automated bat-tests OK
All Apps working
No new findings.

@johannarautanen johannarautanen added Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin labels May 27, 2024
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 28, 2024 07:12 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 04:15 — with GitHub Actions Inactive
@brianmcgillion
Bump unstable with procmail and qemu fix
14bc6d6 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion
Remove xcompile overlay for qemu
490c19d 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 04:39 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 04:59 — with GitHub Actions Inactive
@brianmcgillion
Remove edk2 cross-compilation overlay
25cf1b2 
The fix was merged into mainline
NixOS/nixpkgs#311317

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 07:48 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion removed the Needs Testing CI Team to pre-verify label May 31, 2024
@brianmcgillion
Remove the chromium cross-compile overlays
70c0d8c 
fixed in upstream
NixOS/nixpkgs#299031
NixOS/nixpkgs#308196

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 12:28 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 14:48 — with GitHub Actions Inactive
@brianmcgillion
Remove pipewire cross-compile overlays
ff7ffc4 
fixed in the upstream
NixOS/nixpkgs#310814

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow May 31, 2024 16:19 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion added Needs Testing CI Team to pre-verify and removed Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on NUC This PR has been tested on Intel NUC Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board labels May 31, 2024
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow June 1, 2024 12:55 — with GitHub Actions Inactive
@barnabakos
Copy link
Collaborator

tested with latest commits up to ff7ffc4
platforms: Lenovo X1 Carbon; NVIDIA Jetson AGX Orin

  • ci-test-automation suite passed
  • all apps start
  • no new findings

@barnabakos barnabakos added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled labels Jun 2, 2024
@johannarautanen
Copy link

Test results on native Orin-AGX:

Automated bat-tests OK
All Apps launched
Manual regression test ok.
No new findings.

@johannarautanen johannarautanen added the Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin label Jun 3, 2024
@johannarautanen
Copy link

Test results on native Orin-NX:

Automated bat-tests OK
All Apps launched
Manual regression test ok.
No new findings.

@johannarautanen johannarautanen added the Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin label Jun 3, 2024
@milva-unikie
Copy link

Everything is also working on riscv64 Polarfire.

nixos-version shows 24.11.20240531.803a53c (Vicuña), is that intentional?

@milva-unikie milva-unikie added the Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board label Jun 3, 2024
@milva-unikie
Copy link

Tested on NUC

  • Test-automation passes
  • All apps launch

@milva-unikie milva-unikie added Tested on NUC This PR has been tested on Intel NUC and removed Needs Testing CI Team to pre-verify labels Jun 3, 2024
@brianmcgillion brianmcgillion merged commit 04af95b into tiiuae:main Jun 3, 2024
14 checks passed
@brianmcgillion brianmcgillion deleted the flake-bump-unstable branch June 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbssrc mbssrc mbssrc approved these changes

Assignees
No one assigned
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on NUC This PR has been tested on Intel NUC Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brianmcgillion @milva-unikie @johannarautanen @leivos-unikie @barnabakos @mbssrc