chromium: fix cross compilation

[Mic92]

Description of changes

• Tested native compilation of chromium with native compilation on x86_64-linux and cross-compilation to aarch64-linux
• Before this change we injected cross-compiled libraries into depsDepsBuild inputs.
  This happens because we override the libpng and libopus package mess
  with splicing.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[emilylange]

Can you please share details about this?

Your PR description is empty, and your commit message only reads chromium: fix cross-compilation.

Cross-compilation puts lots of additional strain on chromium, a derivation that is already in a rough shape and heavily struggling to keep up at all.

How did you test your change?
Which architectures did you test?
Did you test electron, which depends on this chromium derivation, at all?

[Mic92]

Can you please share details about this?

Your PR description is empty, and your commit message only reads chromium: fix cross-compilation.

Cross-compilation puts lots of additional strain on chromium, a derivation that is already in a rough shape and heavily struggling to keep up at all.

How did you test your change? Which architectures did you test? Did you test electron, which depends on this chromium derivation, at all?

Updated. Let me know if you need more information. I currently didn't test any other derivations because it seems unlikely to me that adding depsDepsBuild inputs will change anything about them. Let me know if you want to test something in particular, I have enough build resources for that.

[avnik]

@emilylange this should fix #292346 and #292364

[emilylange]

I don't see how c4492425adabbe8e75515753590baf1bf51766ca is needed since #298515 has been merged to staging and will probably land in master the coming weeks.

Additionally, from what I know, xdg-utils not cross-compiling does not prevent a chromium/electron cross compilation build from succeeding.

Amjoseph, who is responsible for most of the cross-compilation work in chromium, added xdg-utils.meta.broken conditionals for this.

I am fine with the cross-compilation fix for chromium (and by proxy electron) itself.
But also note that I won't notice any issues with it if there are some, because I don't know much about cross-compilation.

Would you mind dropping your xdg-utils fix from this PR (because #298515 has been merged instead of this) and rebase and re-target master?

Thanks.

[Mic92]

xdg-utils was used in the chromium shell wrapper. It's not used in the chromium build itself. I can check if #298515 fixes the issue.

[Mic92]

There should be enough engineering capacity in the ghaf project to also ensure in future that cross-compilation will continue to work for chromium.

[emilylange]

xdg-utils was used in the chromium shell wrapper. It's not used in the chromium build itself.

Ah, so my information was outdated. xdg-utils cross-compilation is no longer marked as broken since #246954. I did not notice that. See #225112 and #225114 for context.

That's good to know.

I can check if #298515 fixes the issue.

Would be cool if you could report back when you find some time and compute for this :)

There should be enough engineering capacity in the ghaf project to also ensure in future that cross-compilation will continue to work for chromium.

What is the /graf project/ you are referring to?

[Mic92]

Ghaf is something like QubesOS but using NixOS and KVM-based virtualisation: https://tiiuae.github.io/ghaf/

[Mic92]

My xdg-utils fix is no longer needed. Still waiting for the chromium build to finish.

[Mic92]

However now I found a mesa regression that is new...

[Mic92]

Chromium builds again. Finished from my side.

[emilylange]

Also, is there a reason why you used disabledTestPaths instead of disabledTests?

[Mic92]

There are multiple tests that all break occasionally, listing them manually will possible add regressions in the future because they don't seem to always break.

[emilylange]

Thanks