Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amino acid alphabet #10

Open
tijeco opened this issue Oct 27, 2021 · 0 comments
Open

amino acid alphabet #10

tijeco opened this issue Oct 27, 2021 · 0 comments

Comments

@tijeco
Copy link
Owner

tijeco commented Oct 27, 2021

This is definitely only a minor thing, but I think is worth addressing. I personally only really care about the standard 20 amino acids, so I have no interest in predictions for other amino acids that these models may have support for. For now, I have hard coded the 20 amino acids as a string.

This creates two issues. First, others may be interested in other amino acids that are supported by these models. Second, even if that's not the case, I think it would be better to have a centralized definition of the alphabet instead of hard coding it numerous times in other functions.

What I think would make the most sense is to maybe make a utils module or core module and put things like this here so that other modules just import the alphabet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant