Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error: undefined: push.AddFromGatherer #29

Closed
borodyadka opened this issue Aug 8, 2019 · 3 comments
Closed

Build error: undefined: push.AddFromGatherer #29

borodyadka opened this issue Aug 8, 2019 · 3 comments
Labels
wontfix This issue will not be fixed.

Comments

@borodyadka
Copy link

Hello. Thanks for the library. But I've got an error:

vendor/github.com/tikv/client-go/metrics/push.go:44:10: undefined: push.AddFromGatherer

push.AddFromGatherer was removed from prometheus client in release 1.0.0.

@disksing
Copy link
Collaborator

disksing commented Aug 8, 2019

Hi @borodyadka , the client is now using go mod to manage dependency and the Prometheus client is pinned to v0.9.2. Could you try to migrate your vendored prometheus to 0.9.2 too?
Of course, it is totally reasonable to update to the new stable version. I will create an issue first, and if you are interested, you can help us to upgrade 😄

@borodyadka
Copy link
Author

Hi @disksing , thanks for the answer. I'm not sure I can help you with it, because I don't have enough time for fixing this issue. I'm switch to prometheus 0.9.2 for now.

@stale
Copy link

stale bot commented Dec 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This issue will not be fixed. label Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This issue will not be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants