Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan returning empty results #455

Closed
limbooverlambda opened this issue Jun 17, 2024 · 1 comment
Closed

Scan returning empty results #455

limbooverlambda opened this issue Jun 17, 2024 · 1 comment

Comments

@limbooverlambda
Copy link
Contributor

limbooverlambda commented Jun 17, 2024

We were running into an issue with scans where periodically we noticed scans returning empty results for datasets that were present in a cluster. The hypothesis was that the scans were returning empties when the regions are undergoing splits. While trying to reproduce the issue (by issuing splits from pd-ctl), we found out that when there's a region error (epoch_version_mismatch et al), the scan_inner is not triggering any cache invalidations and subsequent retries. The scan simply returns an empty. Here's the PR #456 to fix the issue by wrapping the scans in a retryer upon any region errors.

cc: @pingyu @ekexium @andylokandy.

This was referenced Jun 17, 2024
@limbooverlambda
Copy link
Contributor Author

Fix in #456. Thanks @pingyu @iosmanthus @hbisheng @zhangjinpeng87 for shaping the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant