Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rust 2018 #21

Closed
brson opened this issue Jan 3, 2019 · 4 comments
Closed

Upgrade to Rust 2018 #21

brson opened this issue Jan 3, 2019 · 4 comments
Assignees

Comments

@brson
Copy link
Collaborator

brson commented Jan 3, 2019

After TiKV itself is successfully upgraded (tikv/tikv#3896) we can bump fail to Rust 2018 as well. Do a major version bump.

@brson brson self-assigned this Jan 3, 2019
@brson
Copy link
Collaborator Author

brson commented Jan 5, 2019

I have a branch that I think is ready to go here: https://github.com/brson/fail-rs/tree/rust-2018, but waiting until the tikv 2018 upgrade lands without trouble before this one.

@brson
Copy link
Collaborator Author

brson commented Jan 8, 2019

In thinking about backwards compatibility I'm inclined to explicitly break support for Rust 2015 when we do this upgrade - it's possible to be compatible with both (in some situations, I believe), but by doing so we have to be vigilant about breaking 2015 compatibility. I'm inclined to insert some boilerplate code into each of fail, prometheus, and grpc that is definitely 2018 only and breaks the build under 2015 so we don't have to worry about breaking 2015 compatibility in a minor version bump.

Let me know if anybody is opposed to that.

@brson
Copy link
Collaborator Author

brson commented Jan 23, 2019

I have not found a toolchain that both ignores "edition" and successfully interprets crate in paths, so I suspect turning on 2018 will cleanly break compatibility with pre-1.32 toolchains.

@brson
Copy link
Collaborator Author

brson commented Jan 23, 2019

The tikv toolchain is upgraded to a version that supports 2018 now, so I think once it's had a few days on master w/o being reverted it's safe to go ahead. I'll do so sometime next week.

@brson brson mentioned this issue Jan 28, 2019
@brson brson closed this as completed in #26 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant