Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: support custom client timeout (#2480) #2509

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 5, 2020

What problem does this PR solve?

cherry-pick #2480.

What is changed and how it works?

This PR adds a new field in base client named timeout and it can be changed when we use WithCustomTimeoutOption to create a new client.

Check List

Tests

  • Unit test

Release note

  • Support setting a custom timeout for PD client

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added this to the v4.0.1 milestone Jun 5, 2020
@rleungx rleungx requested review from nolouch and disksing June 5, 2020 03:59
@lhy1024
Copy link
Contributor

lhy1024 commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Jun 5, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit b9cb120 into tikv:release-4.0 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants