client: support custom client timeout #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
disksing
approved these changes
Jun 1, 2020
|
/approve |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jun 5, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
sre-bot
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #2473
What is changed and how it works?
This PR adds a new field in base client named
timeoutand it can be changed when we useWithCustomTimeoutOptionto create a new client.Check List
Tests
Unit test
need to add a unit test
Release note