Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags when upload test coverage to codecov.io #6667

Closed
2 tasks
wuhuizuo opened this issue Jun 25, 2023 · 0 comments · Fixed by #6666
Closed
2 tasks

Add flags when upload test coverage to codecov.io #6667

wuhuizuo opened this issue Jun 25, 2023 · 0 comments · Fixed by #6666
Labels
type/development The issue belongs to a development tasks

Comments

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 25, 2023 •
edited
Loading

Development Task

  • add flags management in codecov.yaml to separate unit and integration testing coverage.
  • ignore the tests dir, it's for integration tests.

Ref:
@wuhuizuo wuhuizuo added the type/development The issue belongs to a development tasks label Jun 25, 2023
@wuhuizuo wuhuizuo mentioned this issue Jun 25, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #6666 Jul 3, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 3, 2023
@wuhuizuo
ci: add configuration fileds to codecov.yaml (#6666)
626d1c8 
ref PingCAP-QE/ci#2171, close #6667

ci: add configuration fileds to codecov.yaml

- `ignore`: ignore integration test cases or tools paths.
- `flags`: to split static for unit and integration testing.
- `comment`: add `flags` section in comments.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@JmPotato JmPotato mentioned this issue Aug 2, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Aug 2, 2023
@JmPotato @ti-chi-bot
codecov: only ignore the tool tests (#6881)
d664827 
ref #6667

Given that a significant portion of the PD code test is dependent on the integration tests,
which are essential for covering certain code scenarios, such as the testing of the `mcs` pkg
that specifically requires integration with an actual PD cluster, it becomes imperative to factor
these aspects into the codecov analysis.

This PR modifies the `codecov.yml` file to exclude solely the tool tests from the coverage analysis.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/development The issue belongs to a development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add configuration fileds to codecov.yaml wuhuizuo/pd
1 participant
@wuhuizuo