Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe recovery: Fix learner nodes got ignored in auto detect mode error (#6691) #6708

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6691

What problem does this PR solve?

Issue Number: Close #6690

What is changed and how does it work?

Fix learner nodes got ignored in auto detect mode error

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

This PR does not need to be cherry-picked into release 6.5, since the customized PR #6683 will be.

Release note

None.

ref tikv#6683, close tikv#6690

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx June 29, 2023 01:15
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 3, 2023

could you please fix the conflict? @v01dstar

@v01dstar
Copy link
Contributor

v01dstar commented Jul 3, 2023

could you please fix the conflict? @v01dstar
We can close this cherry-pick, just checked that the bug only occurs after "auto mode" was introduced, it does not exist in 6.1

@ti-chi-bot ti-chi-bot closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants