Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe recovery hang in auto detect mode. #6690

Closed
v01dstar opened this issue Jun 27, 2023 · 2 comments · Fixed by #6691
Closed

Unsafe recovery hang in auto detect mode. #6690

v01dstar opened this issue Jun 27, 2023 · 2 comments · Fixed by #6691
Labels
affects-6.1 affects-6.5 affects-7.1 severity/major The issue's severity is major. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports

Comments

@v01dstar
Copy link
Contributor

Bug Report

Unsafe recovery hang in auto detect mode, since learner replicas/ stores are ignored, not considered failed stores.
@v01dstar v01dstar added the type/bug The issue is confirmed as a bug. label Jun 27, 2023
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports Jun 27, 2023
This was referenced Jun 27, 2023
Merged
Merged
@CabinfeverB CabinfeverB added the severity/major The issue's severity is major. label Jun 27, 2023
@CabinfeverB
Copy link
Member

IMO, it affects 6.1 6.5. 7.1. Can you confirm this？

@v01dstar
Copy link
Contributor Author

IMO, it affects 6.1 6.5. 7.1. Can you confirm this？

Yes, that's correct.

Questions and Bug Reports automation moved this from Need Triage to Closed Jun 29, 2023
ti-chi-bot bot added a commit that referenced this issue Jun 29, 2023
@v01dstar @ti-chi-bot
unsafe recovery: Fix learner nodes got ignored in auto detect mode er…
610aee7 
…ror (#6691)

ref #6683, close #6690

Fix learner nodes got ignored in auto detect mode error

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 29, 2023
@v01dstar @ti-chi-bot
This is an automated cherry-pick of tikv#6691
feafae5 
ref tikv#6683, close tikv#6690

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 29, 2023
@v01dstar @ti-chi-bot @ti-chi-bot
unsafe recovery: Fix learner nodes got ignored in auto detect mode er…
6fb1419 
…ror (tikv#6691)

ref tikv#6683, close tikv#6690

Fix learner nodes got ignored in auto detect mode error

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 29, 2023
@v01dstar @ti-chi-bot @ti-chi-bot
unsafe recovery: Fix learner nodes got ignored in auto detect mode er…
c2aaf20 
…ror (tikv#6691)

ref tikv#6683, close tikv#6690

Fix learner nodes got ignored in auto detect mode error

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This was referenced Jul 3, 2023
Closed
Merged
ti-chi-bot bot added a commit that referenced this issue Jul 4, 2023
@v01dstar @ti-chi-bot
unsafe recovery: Fixing learner store being ignored error (#6683)
15324c5 
ref #6690, ref #6709

Fix learner store/ replica being ignored error in auto detect mode.

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this issue Jul 5, 2023
@v01dstar @ti-chi-bot
unsafe recovery: Fixing learner store being ignored error in 7.1 (#6744)
9954576 
ref #6690, ref #6710

Fix learner store/ replica being ignored error in auto detect mode.

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 5, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jul 5, 2023
@v01dstar @ti-chi-bot
This is an automated cherry-pick of tikv#6744
b541e10 
ref tikv#6690, ref tikv#6710

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.5 affects-7.1 severity/major The issue's severity is major. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unsafe recovery: Fix learner nodes got ignored in auto detect mode error v01dstar/pd
2 participants
@v01dstar @CabinfeverB