-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsafe recovery bug in 6.1 #6743
Conversation
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @nolouch @Connor1996 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no test?
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## release-6.1 #6743 +/- ##
===============================================
+ Coverage 75.55% 75.57% +0.01%
===============================================
Files 307 307
Lines 30567 30565 -2
===============================================
+ Hits 23096 23099 +3
- Misses 5471 5475 +4
+ Partials 2000 1991 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Actually, this bug does not exist in 6.1, since it has no "auto detect" mode, closing this PR |
What problem does this PR solve?
Issue Number: Ref #6690
What is changed and how does it work?
Check List
Tests
This has been tested in the main branch.
Code changes
Side effects
Related changes
Release note