Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe recovery bug in 6.1 #6743

Closed
wants to merge 1 commit into from

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Jul 3, 2023

What problem does this PR solve?

Issue Number: Ref #6690

What is changed and how does it work?

Fix learner nodes got ignored in auto detect mode error

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    This has been tested in the main branch.

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jul 3, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx July 3, 2023 22:45
@v01dstar
Copy link
Contributor Author

v01dstar commented Jul 3, 2023

/cc @nolouch @Connor1996

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2023
@ti-chi-bot ti-chi-bot bot requested review from Connor1996 and nolouch July 3, 2023 22:45
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test?

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (3dc0cc3) 75.55% compared to head (2b097b4) 75.57%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.1    #6743      +/-   ##
===============================================
+ Coverage        75.55%   75.57%   +0.01%     
===============================================
  Files              307      307              
  Lines            30567    30565       -2     
===============================================
+ Hits             23096    23099       +3     
- Misses            5471     5475       +4     
+ Partials          2000     1991       -9     
Flag Coverage Δ
unittests 75.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/unsafe_recovery_controller.go 82.53% <ø> (+0.29%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@v01dstar v01dstar closed this Jul 3, 2023
@v01dstar
Copy link
Contributor Author

v01dstar commented Jul 3, 2023

no test?

Actually, this bug does not exist in 6.1, since it has no "auto detect" mode, closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants