-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please also create git tags while releasing new crate versions #139
Comments
The only maintainer of this project @YangKeao cannot push directly (so he cannot push tags). He rarely contributes to the Maybe when he is not that tired, he'd like to contact someone who knows the community rule of the tikv to help him solve the problem. |
Based on my knowledge, only tikv committers can push tags directly. Possible solutions include as follows:
Also, ping @tisonkun for more advice about the current situation. Databend depends heavily on |
I will raise this issue to tikv/community to get more ideas. |
Ping all maintainers of |
@YangKeao you have |
Sorry for the misleading. As I just tried, I can push a tag (v0.9.1), but cannot push to master directly, is it expected?
I think it's fine to push the tags 😆 . I'll tag some old releases to fix this problem. Then the release process would be: @YangKeao submits a PR to upgrade the version, after it's merged, he will tag the commit and push the tag. |
I think it's expected. the
Looks good to me! |
Maybe we can integrate with a GitHub Action to automatically create release (and possibly upload to crates.io?) Some examples: https://github.com/risinglightdb/sqllogictest-rs/blob/main/.github/workflows/release.yml |
Automatically publishing on crates.io is pretty cool, maybe I could add a bot as the owner of this crate, and publish the crate through bot's token 🤔 . |
So that users know which commits we are on.
The text was updated successfully, but these errors were encountered: