cannot compile this crate

[petar-dambovaliev]

If it can't compile without the flamegraph feature, why is it optional?

pub enum Output<'a> {
    #[cfg(feature = "flamegraph")]
    Flamegraph(Option<FlamegraphOptions<'a>>),

    #[cfg(feature = "protobuf")]
    Protobuf,
}

 |
17 | pub enum Output<'a> {
   |                 ^^ unused parameter
   |

[YangKeao]

Oh, sorry! It seems that this problem only occurs when criterion feature is enabled without flamegraph. I will try to fix it right now! The problem locates at:

pub enum Output<'a> {
    #[cfg(feature = "flamegraph")]
    Flamegraph(Option<FlamegraphOptions<'a>>),

    #[cfg(feature = "protobuf")]
    Protobuf,
}

When flamegraph is not enabled, the 'a is an unused parameter. I don't know what's the best practice to fix this problem 🤦‍♂️ . Adding a PhantomData option for this enum is a little wired (or needs exhaustive_patterns).

Maybe writing different enum definitions for different conditions is the best choice, though ugly.