-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tested examples in src/lib.rs Rustdocs #70
Comments
@Hoverbear this will be my first PR in the Rust ecosystem, but I would be willing to give this a shot over the coming weekend 02/16-02/17. |
@KeeganMyers Oh, amazing! What an honor. 🙇♀️ I'll make sure to keep an eye on this issue over the weekend. Let me know how I can help. Progress one or more examples would be a great PR. :) The API can be a bit confusing, feel encouraged to ask questions. |
Sorry for the delay I have added hidden boilerplate to make all the examples pass. I did note that in the integration tests there are several errors: test integration_cases::test_raft_paper::test_leader_election_in_one_round_rpc ... ok test integration_cases::test_raft_snap::test_snapshot_succeed ... ok test integration_cases::test_raft::test_restore_learner_promotion ... ok test integration_cases::test_raft::test_add_node_check_quorum ... ok Should I explore and resolve these or are they outside of the scope of this issue? |
@KeeganMyers Those are expected errors where we are testing to make sure Raft properly reports the error. It's ok. :) If you see the |
#69 introduces examples for usage to src/lib.rs. However most of them are not actually compiled or tested.
We would like them to remove the
ignore
from the code fences so the examples are tested.Please use hiding in the examples to keep the redundant setup code from getting in the way.
@Hoverbear is very happy to help mentor this issue. Just ping. :)
The text was updated successfully, but these errors were encountered: