Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rocksdb SyncPoint to support fail-rs #361

Open
4 tasks
yiwu-arbug opened this issue Oct 25, 2019 · 5 comments
Open
4 tasks

Use rocksdb SyncPoint to support fail-rs #361

yiwu-arbug opened this issue Oct 25, 2019 · 5 comments

Comments

@yiwu-arbug
Copy link
Collaborator

To allow integration test frameworks to control rocksdb internals, we can make use of rocksdb SyncPoint to support rust fail-point https://github.com/tikv/fail-rs There are some difference between SyncPoint and fail-point. Some of the items to work on:

  • Make fail-point support dependencies (one fail-point wait for another before proceed)
  • Make SyncPoint support early return
  • Add rocksdb compile flag to enable SyncPoint in release build
  • Expose SyncPoint API on rocksdb side, then wrap it as fail-point API on rust-rocksdb side
@yiwu-arbug
Copy link
Collaborator Author

cc @Connor1996

@Connor1996
Copy link
Member

Very useful!

@Connor1996 Connor1996 self-assigned this Oct 25, 2019
@Connor1996 Connor1996 removed their assignment Nov 14, 2019
@Sullivan12138
Copy link

I would like to take this task, and choose the exposing syncpoint's API part

@Connor1996 Connor1996 mentioned this issue Nov 25, 2019
Open
@yiwu-arbug
Copy link
Collaborator Author

facebook/rocksdb#6087

@Sullivan12138
Copy link

Sorry, there's another task that invite me to do, so I may have to quit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yiwu-arbug @Connor1996 @Sullivan12138