Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot enhancement #2609

Open
BusyJay opened this issue Dec 22, 2017 · 0 comments
Open

Snapshot enhancement #2609

BusyJay opened this issue Dec 22, 2017 · 0 comments
Labels
component/gRPC Component: gRPC sig/raft Component: Raft, RaftStore, etc. type/enhancement The issue or PR belongs to an enhancement.

Comments

@BusyJay
Copy link
Member

BusyJay commented Dec 22, 2017

There are two enhancements can be made in our raft snapshot mechanism:

  1. When snapshot of lock cf has no keys, the file should not be generated.
  2. When received a snapshot file, it should be synced to avoid possible snapshot corruption due to power failure.

When sync is called, it should also be considered that the receiving thread should not be blocked, which otherwise may cause OOM. Maybe gRPC flow control mechanism can be utilized here.
@BusyJay BusyJay added type/enhancement The issue or PR belongs to an enhancement. component/gRPC Component: gRPC sig/raft Component: Raft, RaftStore, etc. labels Dec 22, 2017
@absolute8511 absolute8511 mentioned this issue Jun 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/gRPC Component: gRPC sig/raft Component: Raft, RaftStore, etc. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BusyJay