Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: don't resize binary opaque when the type flen is unspecified #16617

Merged
merged 2 commits into from Mar 12, 2024
Merged

copr: don't resize binary opaque when the type flen is unspecified #16617

merged 2 commits into from Mar 12, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Mar 7, 2024 •
edited

What is changed and how it works?

Issue Number: Close #16616

What's Changed:

If the flen is unspecified (-1), don't resize the string to try to produce extra zero. ref pingcap/tidb#51586

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao
don't resize vector when the type flen is unspecified
f3d57bf 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

YangKeao commented Mar 8, 2024

/cc @breezewish @gengliqi

@ti-chi-bot ti-chi-bot bot requested review from breezewish and gengliqi March 8, 2024 05:59
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 8, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval do-not-merge/needs-triage-completed labels Mar 11, 2024
@breezewish
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 5a5a631

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Mar 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5a12e2b into tikv:master Mar 12, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 12, 2024
dbsid pushed a commit to dbsid/tikv that referenced this pull request Mar 24, 2024
@YangKeao @breezewish @dbsid
copr: don't resize binary opaque when the type flen is unspecified (t…
9bdb897 
…ikv#16617)

close tikv#16616

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>

Co-authored-by: Wenxuan <breezewish@outlook.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
@YangKeao
Copy link
Member Author

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@YangKeao: new pull request created to branch release-6.5: #16711.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2024
Merged
9 tasks
@YangKeao
Copy link
Member Author

/cherry-pick release-7.1
/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@YangKeao: new pull request created to branch release-7.1: #16712.

In response to this:

/cherry-pick release-7.1
/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2024
Merged
9 tasks
@ti-chi-bot
Copy link
Member

@YangKeao: new pull request created to branch release-7.5: #16713.

In response to this:

/cherry-pick release-7.1
/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2024
Open
9 tasks
ti-chi-bot bot added a commit that referenced this pull request Apr 1, 2024
@ti-chi-bot @YangKeao @ti-chi-bot
copr: don't resize binary opaque when the type flen is unspecified (#…
1db3656 
…16617) (#16711)

close #16616

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>

Co-authored-by: Yang Keao <yangkeao@chunibyo.icu>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Apr 18, 2024
@ti-chi-bot @YangKeao @ti-chi-bot
copr: don't resize binary opaque when the type flen is unspecified (#…
77c2c7f 
…16617) (#16712)

close #16616

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>

Co-authored-by: Yang Keao <yangkeao@chunibyo.icu>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees
No one assigned
Labels
release-note-none size/S status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

TiKV will panic if cast a temporary binary to json
4 participants
@YangKeao @breezewish @ti-chi-bot @gengliqi