Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: don't resize slice to get extra zero when the length is unspecified #51586

Merged
merged 1 commit into from Mar 12, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Mar 7, 2024

What problem does this PR solve?

Issue Number: close #51547

Problem Summary:

What changed and how does it work?

If the flen of a binary string is unspecified, don't resize the target json opaque.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #51586 (0e8e5d8) into master (87bcf32) will increase coverage by 2.3436%.
Report is 44 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51586        +/-   ##
================================================
+ Coverage   70.7575%   73.1012%   +2.3436%     
================================================
  Files          1467       1473         +6     
  Lines        436400     448203     +11803     
================================================
+ Hits         308786     327642     +18856     
+ Misses       108246     100356      -7890     
- Partials      19368      20205       +837     
Flag Coverage Δ
integration 50.2926% <100.0000%> (?)
unit 70.4947% <50.0000%> (-0.0644%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.0436% <ø> (+5.1876%) ⬆️

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao requested review from windtalker and removed request for XuHuaiyu March 8, 2024 05:57
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 10:13:18.96285344 +0000 UTC m=+334825.985099823: ☑️ agreed by xhebox.
  • 2024-03-12 10:12:29.812375726 +0000 UTC m=+766776.834622114: ☑️ agreed by windtalker.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52194.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52195.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52196.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
YangKeao added a commit to ti-chi-bot/tidb that referenced this pull request Apr 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FATAL] [lib.rs:477] ["called Result::unwrap() on an Err value: TryFromIntError(())"]
5 participants