New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json: don't resize slice to get extra zero when the length is unspecified #51586
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51586 +/- ##
================================================
+ Coverage 70.7575% 73.1012% +2.3436%
================================================
Files 1467 1473 +6
Lines 436400 448203 +11803
================================================
+ Hits 308786 327642 +18856
+ Misses 108246 100356 -7890
- Partials 19368 20205 +837
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #51547
Problem Summary:
What changed and how does it work?
If the
flen
of a binary string is unspecified, don't resize the target json opaque.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.